Update emnapi 1.7.1 → 1.8.1 (minor) #19547
Conversation
WalkthroughThe pull request updates the 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @crates/node/package.json:
- Around line 35-39: The lockfile is out of sync with package.json: update
pnpm-lock.yaml so the emnapi bump to "1.8.1" is reflected (including resolved
packages @emnapi/runtime and @emnapi/core moving from 1.5.0 to 1.8.1). Run pnpm
install (from the package.json location or repo root) to regenerate
pnpm-lock.yaml, verify the lockfile now pins @emnapi/runtime and @emnapi/core to
1.8.1, and commit the updated pnpm-lock.yaml alongside the package.json change.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
crates/node/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Linux / postcss
- GitHub Check: Linux / cli
- GitHub Check: Linux / upgrade
- GitHub Check: Linux / vite
- GitHub Check: Linux
- GitHub Check: macOS
- GitHub Check: Windows
| "devDependencies": { | ||
| "@napi-rs/cli": "3.4.1", | ||
| "@napi-rs/wasm-runtime": "^1.1.1", | ||
| "emnapi": "1.7.1" | ||
| "emnapi": "1.8.1" | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Check if pnpm-lock.yaml exists
if fd -H '^pnpm-lock\.yaml$' 2>/dev/null | head -1; then
echo "==> pnpm-lock.yaml found"
lockfile=$(fd -H '^pnpm-lock\.yaml$' 2>/dev/null | head -1)
echo "Checking for emnapi references..."
rg -n "emnapi" "$lockfile" -A 2 -B 2 | head -100
else
echo "No pnpm-lock.yaml found in repository"
fiRepository: tailwindlabs/tailwindcss
Length of output: 1410
🌐 Web query:
emnapi 1.8.1 release notes Node.js compatibility
💡 Result:
emnapi 1.8.1 (the @emnapi/runtime package exists at v1.8.1) requires Node.js >= v16.15.0 at runtime; the repository itself lists Node.js >= v22.12.0 for development. [1][2]
Sources:
- emnapi README (prerequisites: "Node.js >= v22.12.0 for developing..., >= v16.15.0 for user runtime"). [1]
- @emnapi/runtime v1.8.1 package listing (jsDelivr). [2]
Lockfile update required: pnpm-lock.yaml has not been updated to match the package.json emnapi version.
The pnpm-lock.yaml in crates/node/npm/wasm32-wasi/ currently resolves to @emnapi/runtime@1.5.0 and @emnapi/core@1.5.0, but package.json specifies "emnapi": "1.8.1". The lockfile must be regenerated to reflect the version bump.
emnapi 1.8.1 is compatible with Node >=20 (requires only >=16.15.0), so the dependency upgrade itself is sound; however, the lockfile mismatch must be resolved before merging.
🤖 Prompt for AI Agents
In @crates/node/package.json around lines 35 - 39, The lockfile is out of sync
with package.json: update pnpm-lock.yaml so the emnapi bump to "1.8.1" is
reflected (including resolved packages @emnapi/runtime and @emnapi/core moving
from 1.5.0 to 1.8.1). Run pnpm install (from the package.json location or repo
root) to regenerate pnpm-lock.yaml, verify the lockfile now pins @emnapi/runtime
and @emnapi/core to 1.8.1, and commit the updated pnpm-lock.yaml alongside the
package.json change.
|
Sorry, but the merge failed with:
|
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ emnapi (1.7.1 → 1.8.1) · Repo
Release Notes
1.8.1
1.8.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 4 commits:
1.8.1[Backport] feat: add support for Float16Array (#191)1.8.0[Backport] feat: add node_api_set_prototype (#189)Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands