-
-
Notifications
You must be signed in to change notification settings - Fork 5k
Add funding info to package.json #19534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request adds a 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @packages/tailwindcss/package.json:
- Line 13: Add the missing "funding": "https://tailwindcss.com/sponsor" field to
the package.json for the @tailwindcss-node package (update
packages/@tailwindcss-node/package.json) so it matches the other packages; also
inspect packages/internal-example-plugin/package.json and, if it is a
published/public package, add the same funding field, otherwise document/leave
it out if it's internal/example-only. Ensure the field is a top-level key in
package.json alongside the existing metadata.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
packages/@tailwindcss-browser/package.jsonpackages/@tailwindcss-cli/package.jsonpackages/@tailwindcss-postcss/package.jsonpackages/@tailwindcss-standalone/package.jsonpackages/@tailwindcss-upgrade/package.jsonpackages/@tailwindcss-vite/package.jsonpackages/tailwindcss/package.json
🔇 Additional comments (2)
packages/@tailwindcss-standalone/package.json (1)
14-14: LGTM! Consistent with other packages.The funding field is correctly formatted and uses the same sponsor URL as other packages in the monorepo, ensuring consistency.
packages/@tailwindcss-browser/package.json (1)
15-15: The funding field is correctly formatted and consistent with other packages in the repository.The string URL format follows npm conventions and is already used identically in @tailwindcss-cli, @tailwindcss-postcss, and the core tailwindcss packages. The sponsorship URL is accessible and the field is positioned appropriately within the package.json structure.
| }, | ||
| "bugs": "https://github.com/tailwindlabs/tailwindcss/issues", | ||
| "homepage": "https://tailwindcss.com", | ||
| "funding": "https://tailwindcss.com/sponsor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify URL accessibility and completeness of funding field
echo "=== 1. Testing URL Accessibility ==="
response_code=$(curl -s -o /dev/null -w "%{http_code}" "https://tailwindcss.com/sponsor")
echo "Response code: $response_code"
echo -e "\n=== 2. Finding all package.json files in packages/ ==="
fd -t f '^package\.json$' packages/ || echo "No packages found or fd error"
echo -e "\n=== 3. Checking which packages have funding field ==="
echo "Packages WITH funding field:"
fd -t f '^package\.json$' packages/ -x sh -c 'if grep -q "\"funding\"" "$1"; then echo "$1"; fi' sh {} \;
echo -e "\nPackages WITHOUT funding field:"
fd -t f '^package\.json$' packages/ -x sh -c 'if ! grep -q "\"funding\"" "$1"; then echo "$1"; fi' sh {} \;
echo -e "\n=== 4. Summary ==="
total=$(fd -t f '^package\.json$' packages/ | wc -l)
with_funding=$(fd -t f '^package\.json$' packages/ -x sh -c 'if grep -q "\"funding\"" "$1"; then echo "$1"; fi' sh {} \; | wc -l)
echo "Total packages: $total"
echo "With funding: $with_funding"
echo "Without funding: $((total - with_funding))"Repository: tailwindlabs/tailwindcss
Length of output: 1117
Add funding field to remaining packages.
The sponsor URL is accessible (HTTP 200). However, the funding field is only present in 7 of 9 packages. Two packages are missing it:
packages/@tailwindcss-node/package.jsonpackages/internal-example-plugin/package.json
Add the "funding": "https://tailwindcss.com/sponsor" field to @tailwindcss-node for consistency. Verify whether internal-example-plugin should have it (appears to be an internal/example package).
🤖 Prompt for AI Agents
In @packages/tailwindcss/package.json at line 13, Add the missing "funding":
"https://tailwindcss.com/sponsor" field to the package.json for the
@tailwindcss-node package (update packages/@tailwindcss-node/package.json) so it
matches the other packages; also inspect
packages/internal-example-plugin/package.json and, if it is a published/public
package, add the same funding field, otherwise document/leave it out if it's
internal/example-only. Ensure the field is a top-level key in package.json
alongside the existing metadata.
|
Well done! |
Just noticed funding property in
package.jsonfiles had not been set, perhaps by choice, but just in case.Summary
Adding funding information to package.json files, such that users of Tailwind CSS might become aware of sponsor opportunities.
Test plan
NA. Will give funding info upon package installation and running
npm fund.