-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Use URL almost everywhere #6408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Here's an example of your CHANGELOG entry: * Use URL almost everywhere.
[SimplyDanny](https://github.com/SimplyDanny)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
27785a7 to
3f8ba86
Compare
An assortment of fixes that improve the test coverage on Windows. With this set, local testing reveals 1 failure (RemoteCycleDetection) and another set of test failures due to Windows globbing not matching the POSIX semantics.
c5bfa40 to
665f36b
Compare
compnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go through this extremely carefully, but it does seem like it is a significant improvement. Some of this should actually improve performance too (due to the migration to the new API constructs).
No description provided.