Skip to content

Conversation

@SimplyDanny
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 3, 2026

2 Warnings
⚠️ Big PR
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
19 Messages
📖 Building this branch resulted in a binary size of 27283.96 KiB vs 27222.4 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.75 s vs 0.78 s on main (3% faster).
📖 Linting Alamofire with this PR took 0.99 s vs 1.0 s on main (1% faster).
📖 Linting Brave with this PR took 6.94 s vs 6.83 s on main (1% slower).
📖 Linting DuckDuckGo with this PR took 22.64 s vs 22.52 s on main (0% slower).
📖 Linting Firefox with this PR took 10.99 s vs 10.98 s on main (0% slower).
📖 Linting Kickstarter with this PR took 7.46 s vs 7.56 s on main (1% faster).
📖 Linting Moya with this PR took 0.4 s vs 0.4 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 2.22 s vs 2.3 s on main (3% faster).
📖 Linting Nimble with this PR took 0.6 s vs 0.66 s on main (9% faster).
📖 Linting PocketCasts with this PR took 6.97 s vs 7.24 s on main (3% faster).
📖 Linting Quick with this PR took 0.37 s vs 0.42 s on main (11% faster).
📖 Linting Realm with this PR took 3.23 s vs 3.28 s on main (1% faster).
📖 Linting Sourcery with this PR took 1.75 s vs 1.79 s on main (2% faster).
📖 Linting Swift with this PR took 4.3 s vs 4.28 s on main (0% slower).
📖 Linting SwiftLintPerformanceTests with this PR took 0.32 s vs 0.29 s on main (10% slower).
📖 Linting VLC with this PR took 1.05 s vs 1.1 s on main (4% faster).
📖 Linting Wire with this PR took 17.41 s vs 17.35 s on main (0% slower).
📖 Linting WordPress with this PR took 11.53 s vs 11.4 s on main (1% slower).

Here's an example of your CHANGELOG entry:

* Use URL almost everywhere.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the url-almost-everywhere branch 20 times, most recently from 27785a7 to 3f8ba86 Compare January 11, 2026 14:11
compnerd and others added 5 commits January 11, 2026 20:55
An assortment of fixes that improve the test coverage on Windows. With
this set, local testing reveals 1 failure (RemoteCycleDetection) and
another set of test failures due to Windows globbing not matching the
POSIX semantics.
@SimplyDanny SimplyDanny force-pushed the url-almost-everywhere branch from c5bfa40 to 665f36b Compare January 11, 2026 20:01
@SimplyDanny SimplyDanny marked this pull request as ready for review January 11, 2026 20:33
Copy link
Contributor

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through this extremely carefully, but it does seem like it is a significant improvement. Some of this should actually improve performance too (due to the migration to the new API constructs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants