Improved pull request "Files Changed" experience feedback #163932
Replies: 2543 comments 974 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
On the new view, there's a very annoying issue with the "Finish your review" dropdown. It appears the text box is ephemeral and its state is not preserved when the dropdown is closed, as it was in the old experience. Often I will want to close the dropdown to browse files while I am finalizing my review, and even more often I will accidentally press the "esc" button while typing, which closes the dropdown. Please fix this as it's a major barrier to my adoption of the new experience. |
Beta Was this translation helpful? Give feedback.
-
|
In the new view, I'm not able to go to the next comment or file using j/k keyboard shortcuts. The new view is great btw!! |
Beta Was this translation helpful? Give feedback.
-
|
Showing 1 file at a time is a hard pass for me. Please don't do that ever |
Beta Was this translation helpful? Give feedback.
-
That's really unhelpful showing 40 comments only and I couldn't find the unresolved comment to get my PR merged. And there seem no filter to help me finding the unresolved comment. P.S. I asked Claude to find and resolve the comment for me, instead of myself finding it out in GitHub. |
Beta Was this translation helpful? Give feedback.
-
|
Hello, the UI could be improved, I would like a "jump to next thing not reviewed" in the new UI, I have to manually go 1 by 1 checking which ones are reviewed which is not good. Also in the left panel would be good to have the same [viewed] mark with a check mark to more easily see what is actually reviewed at a high level there. |
Beta Was this translation helpful? Give feedback.
-
|
This is terrible on mobile, please never roll this out. |
Beta Was this translation helpful? Give feedback.
-
|
I think my UI got updated. (Or did I manually change to the new design? 🤔) (There is obviously also things I like about the new design, feels a bit cleaner overall, but the above issue is pretty annoying.) |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
on mobile web for some reason page keeps scrolling up during the scroll, makes it impossible to use this new view on mobile web browsers |
Beta Was this translation helpful? Give feedback.
-
|
@Akash1134 Code Button -> Dropdown -> Checkout with GitHub Desktop doesn't work |
Beta Was this translation helpful? Give feedback.
-
|
Dear Akash, Thanks for the detailed update! It is awesome to see just how much emphasis is being placed on performance, accessibility, and review readability, especially for large pull requests! The features such as commenting on any line, Overview panel, previews for pending comments, and resizable file trees are absolute game-changers for working with PRs. In particular, I would also like to thank you for being clear in regards to limitations and the need to opt-in for single file mode. Additionally, I am also quite curious to know if there will be any further increases to comment and response limits in the very near future, particularly within huge enterprise repositories. "I’ll be sure to try out the public preview and report any feedback if I come across any edge cases," says Eric. "Looking forward to seeing how this new experience is implemented." |
Beta Was this translation helpful? Give feedback.
-
|
I'd like to be able to quickly switch between inline and side-by-side-diff for a single file. |
Beta Was this translation helpful? Give feedback.
-
|
On mobile, the new view frequently scrolls to top unexpectedly. Also, in the old setup the split/unified state was stored separately for mobile and full browsers, enabling a preference for each, I’d really value maintaining that ability. Thanks for the performance and usability improvements in the new view though! |
Beta Was this translation helpful? Give feedback.
-
|
Attempting to scroll though "Files Changed" on mobile leads to it re-scroll you back to the top of the page the moment you let go of the scroll! |
Beta Was this translation helpful? Give feedback.
-
|
I've been testing the new experience and want to echo some of the critical issues mentioned by others: Mobile scrolling bug: On mobile browsers, the page automatically jumps back to the top when you release the scroll - this makes it nearly impossible to review PRs on mobile. This needs urgent attention. Review comment text loss: The "Finish your review" dropdown doesn't preserve the text when it's closed. I've accidentally lost lengthy review comments by pressing ESC or clicking outside. The old experience kept this text persistent, which was essential for my workflow. Missing visual indicators: The "Changed since last view" label is missing, making it difficult to differentiate between files that haven't been reviewed at all versus files that were reviewed but have since changed. Positive feedback: I do appreciate the performance improvements, the resizable file tree, and the comment indicators in the sidebar. The new overview panel is also quite useful. Hoping these issues get prioritized - the new experience has great potential but these bugs are currently blocking full adoption for many reviewers. |
Beta Was this translation helpful? Give feedback.


















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Important
We're actively working to improve performance. As part of this, the single file mode, which was a temporary solution while we addressed scale and performance issues, will transition to an "opt-in" feature rather than one that is forced on because of the size of the pull request. We're also working to increase the limits on comments, etc.
We know appreciate your patience! ❤️
About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
Tip
To opt into the public preview, click the ✨Try the new experience in the upper-right of the "Files changed" page. You can easily switch back by clicking Switch back.
✨ What's new
See what's been fixed and improved since the launch of the public preview:
User experience
Accessibility
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions