-
Notifications
You must be signed in to change notification settings - Fork 19.5k
refactor(web): setup status caching #30798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @lyzno1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the application's setup status caching mechanism to centralize its handling and improve performance. By introducing a new utility function, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a solid refactoring that centralizes the setup status caching logic into a new utility file, web/utils/setup-status.ts. This improves code organization and reusability. The parallel data fetching in GlobalPublicStoreProvider using useQueries is a great performance enhancement. However, the new utility file directly accesses localStorage without checking for a browser environment, which will cause the application to crash during server-side rendering (SSR). I've added a couple of high-severity comments with suggestions to make the new utility SSR-safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors setup status caching by centralizing the cache handling logic into a reusable utility function. The changes reduce code duplication and improve maintainability by creating a single source of truth for setup status caching behavior.
Key Changes:
- Created
web/utils/setup-status.tswith a centralizedfetchSetupStatusWithCachefunction - Refactored
app-initializer.tsxto use the new utility function - Enhanced
global-public-context.tsxto prefetch setup status in parallel with system features usinguseQueries
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| web/utils/setup-status.ts | New utility module that centralizes setup status caching logic with localStorage |
| web/app/components/app-initializer.tsx | Refactored to use the new shared caching utility instead of inline cache logic |
| web/context/global-public-context.tsx | Enhanced to prefetch setup status in parallel with system features while keeping the prefetch non-blocking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d397ad2 to
d9af65e
Compare
- Remove unused _setupStatusQuery destructuring, only extract featuresQuery - Add comprehensive unit tests for fetchSetupStatusWithCache utility - Update comments to clarify prefetch intent
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
| setSystemFeatures({ ...defaultSystemFeatures, ...data }) | ||
| }, [data, setSystemFeatures]) | ||
| if (featuresQuery.data) | ||
| setSystemFeatures({ ...defaultSystemFeatures, ...featuresQuery.data }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also delete this pattern?
Summary
utils/setup-status.tsWhy This Speeds Up First Load
Before (sequential requests):
After (parallel requests):
Testing
pnpm test utils/setup-status.spec.ts(11 tests passing)pnpm lint:fixpnpm type-check:tsgo