Fix broken link to golangci-lint install instructions #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I do want to mention I am waiting on feedback on Issue #96 to see if the output I got was intended or not. I suspect it is irrelevant for this PR, but I wanted to mention it in case it was relevant. |
octosteve
requested changes
Aug 12, 2025
Use URL for final destination rather than URL that gets redirected.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a broken link in the contributing guidelines by updating the URL for golangci-lint installation instructions to point to the current documentation location.
- Updates the golangci-lint installation link from the old
/usage/install/#local-installationpath to the new/docs/welcome/install/path
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ernest-phillips
approved these changes
Aug 21, 2025
Contributor
ernest-phillips
left a comment
ernest-phillips
left a comment
There was a problem hiding this comment.
Confirmed links worked 👍🏾
Thanks for the fix
octosteve
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix a link that no longer works so someone wanting to contribute will go to the right webpage when trying to install golangci-lint.
fixes Issue #95
What approach did you choose and why?
Simply replaced the old URL with the new one; everything else should be the same. I did this because it was the smallest change I could make while still fixing the issue.
What should reviewers focus on?
It is possible the team actually wants the link to take the user to a different page because the official golangci-lint install page seemed to be a lot. I could see someone getting confused unnecessarily.
An alternate option would be to include instructions for some of the install methods directly in the CONTRIBUTE.md file. If this is desired, feel free to let me know and I will be happy to make that adjustment. Please just tell me if there are any strong preferences on which install methods to include.
Edit: A previous version had the last paragraph saying to include links when I meant to include the instructions themselves.