Skip to content

Conversation

@bevanjkay
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

This makes an adjustment to our signing audit skiplist for homebrew-cask to make it architecture specific. We have seen an increasing number of casks that fail only on the GitHub intel-based CI runners. Making this change allows us to skip these cases once they have been manually verified.

The alternative considered is to skip this audit entirely on the macos-15-intel runner, but I don't believe the issue is widespread enough for this to be the best option at this time.

Needed for: Homebrew/homebrew-cask#234707

Copilot AI review requested due to automatic review settings January 12, 2026 03:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the signing audit skiplist logic in homebrew-cask to support architecture-specific exceptions. Currently, signing audit failures can only be skipped globally for a cask. With this change, casks can be skipped for signing audits on specific architectures (e.g., Intel or ARM) while still being audited on others.

Changes:

  • Updated the audit_signing method to check for architecture-specific skiplist entries before falling back to architecture-agnostic ("all") entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants