PR list doesn't show 'Approved' tag when ruleset has required approvals: 0 #183842
Replies: 2 comments 1 reply
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
Honestly even with the 'Approved' tag appearing as expected, it's hard to quickly see which PRs are approved or which have changes requested because it's just a tiny grey label that blends in to all the other text. I have to inject custom CSS to highlight the label, and to highlight the entire row, which makes it instantly obvious which PRs are approved or have already been reviewed |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Bug
Body
When a ruleset has
Require a pull request before merging -> Required Approvalsset to 0, theApprovedtag/label no longer appears on the repo PR list. I think it's still important to show which PRs are approved, even if that approval is not required before merging.Ideally I'd just set the required approvals to 1, but this is a monorepo shared by other teams in the company who prefer 0 approvals. Without the 'Approved' tag/label appearing, it is really hard to see which PRs are ready to move to the next stage at a glance.
Beta Was this translation helpful? Give feedback.
All reactions